Created a new Microsoft.SecurityInsights preview version - Added onboarding & Offboarding endpoints #12757

yuvalshilo · 2021-02-01T09:38:48Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet
By end of the month (February)
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-01T09:38:50Z

Hi, @yuvalshilo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-02-01T09:38:52Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 9 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- securityinsights/resource-manager/readme.md tag:package-2021-03-preview-only
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- securityinsights/resource-manager/readme.md tag:default

Rule	Message
⚠️ R1006 - PutInOperationName	'PUT' operation 'ProductSettings_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L185
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'ProductSettings_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L38
⚠️ R2057 - InvalidSkuModel	Sku Model definition 'Sku' is not valid. A Sku model must have 'name' property. It can also have 'tier', 'size', 'family', 'capacity' as optional properties. Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L482
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L380
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L408
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: customerManagedKey Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L462
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: eyesOn Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L466
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L507
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Onboard workspace Location: Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json#L275

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 7 Warnings warning [Detail]

The following tags are being changed in this PR

securityinsights/resource-manager/readme.md#package-2021-03-preview-only

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-03-preview-only", "details":"The schema 'SettingList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-03-preview-only", "details":"The schema 'UebaProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-03-preview-only", "details":"The schema 'Sku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-03-preview-only", "details":"The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-03-preview-only", "details":"The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-03-preview-only", "details":"The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2021-03-preview-only", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2021-02-01T09:38:52Z

Thank you for your contribution yuvalshilo! We will review the pull request and get back to you soon.

openapi-pipeline-app · 2021-02-01T09:38:53Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 51ac4e5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 51ac4e5. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md

️✔️securityinsights [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN [email protected] No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 51ac4e5. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityInsights.1.0.0-preview.2.nupkg
- Microsoft.Azure.Management.SecurityInsights.1.0.0-preview.2.snupkg

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 51ac4e5. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md

️✔️@azure/arm-securityinsight [View full logs] [Release SDK Changes]

azure-arm-securityinsight-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityInsights.js → ./dist/arm-securityinsight.js...
cmderr	[npmPack] created ./dist/arm-securityinsight.js in 511ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 51ac4e5. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️securityinsight/mgmt/v1.0/securityinsight [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionPreparer` has been removed
info	[Changelog] - Function `AlertRulesClient.GetActionPreparer` has been removed
info	[Changelog] - Function `AlertRulesClient.DeleteActionSender` has been removed
info	[Changelog] - Function `AlertRulesClient.GetAction` has been removed
info	[Changelog] - Function `AlertRulesClient.DeleteAction` has been removed
info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionResponder` has been removed
info	[Changelog] - Function `AlertRulesClient.DeleteActionPreparer` has been removed
info	[Changelog] - Function `AlertRulesClient.GetActionResponder` has been removed
info	[Changelog] - Function `AlertRulesClient.DeleteActionResponder` has been removed
info	[Changelog] - Function `AlertRulesClient.GetActionSender` has been removed
info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateAction` has been removed
info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionSender` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `ActionsClient.DeletePreparer(context.Context, string, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ActionsClient.CreateOrUpdatePreparer(context.Context, string, string, string, string, ActionRequest) (*http.Request, error)`
info	[Changelog] - New function `ActionsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ActionsClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ActionsClient.DeleteResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `ActionsClient.GetResponder(*http.Response) (ActionResponse, error)`
info	[Changelog] - New function `ActionsClient.CreateOrUpdateResponder(*http.Response) (ActionResponse, error)`
info	[Changelog] - New function `ActionsClient.Delete(context.Context, string, string, string, string) (autorest.Response, error)`
info	[Changelog] - New function `ActionsClient.CreateOrUpdate(context.Context, string, string, string, string, ActionRequest) (ActionResponse, error)`
info	[Changelog] - New function `ActionsClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ActionsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ActionsClient.Get(context.Context, string, string, string, string) (ActionResponse, error)`
info	[Changelog] - New struct `OfficeDataConnectorDataTypesTeams`
info	[Changelog] - New field `TipLookbackPeriod` in struct `TIDataConnectorProperties`
info	[Changelog] - New field `Teams` in struct `OfficeDataConnectorDataTypes`
info	[Changelog] - New field `QueryEndTime` in struct `BookmarkProperties`
info	[Changelog] - New field `QueryStartTime` in struct `BookmarkProperties`
info	[Changelog] - New field `EventTime` in struct `BookmarkProperties`
info	[Changelog]
info	[Changelog] Total 12 breaking change(s), 17 additive change(s).
info	[Changelog]

️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] - New function `WatchlistItemsClient.List(context.Context, string, string, string, string) (WatchlistItemListPage, error)`
info	[Changelog] - New function `*WatchlistItemListIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `TIDataConnector.AsMSTIDataConnector() (*MSTIDataConnector, bool)`
info	[Changelog] - New function `WatchlistItemsClient.CreateOrUpdatePreparer(context.Context, string, string, string, string, string, WatchlistItem) (*http.Request, error)`
info	[Changelog] - New function `MSTICheckRequirements.AsMDATPCheckRequirements() (*MDATPCheckRequirements, bool)`
info	[Changelog] - New function `AADCheckRequirements.AsMSTICheckRequirements() (*MSTICheckRequirements, bool)`
info	[Changelog] - New function `MSTIDataConnector.AsOfficeDataConnector() (*OfficeDataConnector, bool)`
info	[Changelog] - New function `MSTICheckRequirements.AsTICheckRequirements() (*TICheckRequirements, bool)`
info	[Changelog] - New struct `ConnectedEntity`
info	[Changelog] - New struct `EntityEdges`
info	[Changelog] - New struct `IPSyncer`
info	[Changelog] - New struct `IPSyncerSettingsProperties`
info	[Changelog] - New struct `MSTICheckRequirements`
info	[Changelog] - New struct `MSTICheckRequirementsProperties`
info	[Changelog] - New struct `MSTIDataConnector`
info	[Changelog] - New struct `MSTIDataConnectorDataTypes`
info	[Changelog] - New struct `MSTIDataConnectorDataTypesBingSafetyPhishingURL`
info	[Changelog] - New struct `MSTIDataConnectorDataTypesMicrosoftEmergingThreatFeed`
info	[Changelog] - New struct `MSTIDataConnectorProperties`
info	[Changelog] - New struct `MTPCheckRequirementsProperties`
info	[Changelog] - New struct `MTPDataConnector`
info	[Changelog] - New struct `MTPDataConnectorDataTypes`
info	[Changelog] - New struct `MTPDataConnectorDataTypesIncidents`
info	[Changelog] - New struct `MTPDataConnectorProperties`
info	[Changelog] - New struct `MtpCheckRequirements`
info	[Changelog] - New struct `ThreatIntelligenceAlertRule`
info	[Changelog] - New struct `ThreatIntelligenceAlertRuleProperties`
info	[Changelog] - New struct `ThreatIntelligenceAlertRuleTemplate`
info	[Changelog] - New struct `ThreatIntelligenceAlertRuleTemplateProperties`
info	[Changelog] - New struct `ThreatIntelligenceExternalReference`
info	[Changelog] - New struct `ThreatIntelligenceParsedPattern`
info	[Changelog] - New struct `ThreatIntelligenceParsedPatternTypeValue`
info	[Changelog] - New struct `WatchlistItemList`
info	[Changelog] - New struct `WatchlistItemListIterator`
info	[Changelog] - New struct `WatchlistItemListPage`
info	[Changelog] - New struct `WatchlistItemsClient`
info	[Changelog] - New field `Description` in struct `SecurityAlertTimelineItem`
info	[Changelog] - New field `ConsentID` in struct `OfficeConsentProperties`
info	[Changelog] - New field `Edges` in struct `BookmarkExpandResponseValue`
info	[Changelog] - New field `PollingFrequency` in struct `TiTaxiiDataConnectorProperties`
info	[Changelog] - New field `TaxiiLookbackPeriod` in struct `TiTaxiiDataConnectorProperties`
info	[Changelog] - New field `ReceiveDate` in struct `MailMessageEntityProperties`
info	[Changelog] - New field `Edges` in struct `EntityExpandResponseValue`
info	[Changelog] - New field `SubmissionDate` in struct `SubmissionMailEntityProperties`
info	[Changelog] - New field `Submitter` in struct `SubmissionMailEntityProperties`
info	[Changelog] - New field `SubmissionID` in struct `SubmissionMailEntityProperties`
info	[Changelog] - New field `PatternVersion` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `Extensions` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `ParsedPattern` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `Defanged` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `Language` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `ExternalLastUpdatedTimeUtc` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `ObjectMarkingRefs` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `QueryStartTime` in struct `BookmarkProperties`
info	[Changelog] - New field `QueryEndTime` in struct `BookmarkProperties`
info	[Changelog] - New field `EventTime` in struct `BookmarkProperties`
info	[Changelog] - New field `TipLookbackPeriod` in struct `TIDataConnectorProperties`
info	[Changelog]
info	[Changelog] Total 44 breaking change(s), 284 additive change(s).
info	[Changelog]

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 51ac4e5. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-teams' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Actions/put/Creates or updates an action of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get all actions of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get an action of alert rule.
cmderr	[Autorest]     - name: /Actions/delete/Delete an action of alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get all alert rules.
cmderr	[Autorest]     - name: /AlertRules/delete/Delete an alert rule.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
cmderr	[Autorest]     - name: /Bookmarks/put/Creates or updates a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get all bookmarks.
cmderr	[Autorest]     - name: /Bookmarks/delete/Delete a bookmark.
cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Threat Intelligence Platform data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a ASC data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MCAS data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MDATP data connector
cmderr	[Autorest]     - name: /DataConnectors/get/Get a TI data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get all data connectors.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AAD data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AATP data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
cmderr	[Autorest]     - name: /IncidentComments/put/Creates an incident comment.
cmderr	[Autorest]     - name: /IncidentComments/get/Get all incident comments.
cmderr	[Autorest]     - name: /IncidentComments/get/Get an incident comment.
cmderr	[Autorest]     - name: /Incidents/put/Creates or updates an incident.
cmderr	[Autorest]     - name: /Incidents/get/Get all incidents.
cmderr	[Autorest]     - name: /Incidents/get/Get an incident.
cmderr	[Autorest]     - name: /Incidents/delete/Delete an incident.
cmderr	[Autorest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Release Azure CLI Changes]
- sentinel-0.1.0-py3-none-any.whl
- sentinel-0.1.0.zip

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2021-02-01T09:39:02Z

All CLA requirements met.

openapi-workflow-bot · 2021-02-01T09:40:36Z

Hi @yuvalshilo, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

...manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/examples/settings/Onboard.json

...nsights/resource-manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json

ofshomro · 2021-02-01T14:04:41Z

Don't forget to update the readme with a new tag for the new version

...ights/resource-manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json

...nsights/resource-manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json

openapi-workflow-bot · 2021-03-01T16:36:10Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details.

chiragg4u · 2021-03-01T21:08:02Z

@yuval helped me with the changes in a separate PR with #13212
I looked at the changes in onboard/offboard requests and I've only minor nonblocking comments. Adding ARMApproved tag

markcowl

The linting error must be suppressed, otherwise, it will cause failures in every subsequent update. You have previously done this here: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/securityinsights/resource-manager/readme.md#tag-package-2019-01-preview-only

Noted a few other required changes

...nsights/resource-manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json

markcowl · 2021-03-01T21:59:40Z

/azp run

azure-pipelines · 2021-03-01T21:59:54Z

Azure Pipelines successfully started running 2 pipeline(s).

…arding & Offboarding endpoints (Azure#12757) * created new version * fixed comments * fixed errors * fixed prettier * fixedChecks * add readme, fixed custom words * fixedInconsistentSwaggerVersion * fixed readme order * added integer type * fixed validations * fixed reference * removed system data * reset validations * fixed comments * Added system data * moved system data * addedGo * Fixed comments * removed settingsKind Co-authored-by: Yuval Shilo <[email protected]>

created new version

2a4daeb

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 1, 2021

openapi-assignment-bot bot assigned ArcturusZhang Feb 1, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 1, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Feb 1, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 1, 2021

liemilyg suggested changes Feb 1, 2021

View reviewed changes

...manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/examples/settings/Onboard.json Show resolved Hide resolved

...nsights/resource-manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json Outdated Show resolved Hide resolved

fixed comments

f0d0552

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 1, 2021

ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 3, 2021

jorgecotillo reviewed Feb 5, 2021

View reviewed changes

...ights/resource-manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/operations.json Outdated Show resolved Hide resolved

jorgecotillo reviewed Feb 5, 2021

View reviewed changes

...nsights/resource-manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json Show resolved Hide resolved

jorgecotillo reviewed Feb 5, 2021

View reviewed changes

...nsights/resource-manager/Microsoft.SecurityInsights/preview/2021-03-01-preview/Settings.json Show resolved Hide resolved

fixed errors

3410804

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 7, 2021

openapi-sdkautomation bot mentioned this pull request Feb 7, 2021

[AutoPR track2_azure-mgmt-securityinsight] Created a new Microsoft.SecurityInsights preview version - Added onboarding & Offboarding endpoints AzureSDKAutomation/azure-sdk-for-python#4141

Closed

fixed prettier

10f9075

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Mar 1, 2021

openapi-workflow-bot bot added the FixS360 label Mar 1, 2021

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMRevisit labels Mar 1, 2021

markcowl requested changes Mar 1, 2021

View reviewed changes

markcowl removed the Approved-LintDiff label Mar 1, 2021

Azure deleted a comment from azure-pipelines bot Mar 1, 2021

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Mar 1, 2021

YuvalShilo-Microsoft added 2 commits March 8, 2021 12:49

Fixed comments

4a7d54c

removed settingsKind

6b925a9

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Mar 8, 2021

markcowl added Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Mar 8, 2021

markcowl approved these changes Mar 8, 2021

View reviewed changes

markcowl merged commit 51ac4e5 into Azure:master Mar 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created a new Microsoft.SecurityInsights preview version - Added onboarding & Offboarding endpoints #12757

Created a new Microsoft.SecurityInsights preview version - Added onboarding & Offboarding endpoints #12757

yuvalshilo commented Feb 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

ghost commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

ghost commented Feb 1, 2021 •

edited by ghost

Loading

openapi-workflow-bot bot commented Feb 1, 2021

ofshomro commented Feb 1, 2021

openapi-workflow-bot bot commented Mar 1, 2021

chiragg4u commented Mar 1, 2021

markcowl left a comment

markcowl commented Mar 1, 2021

azure-pipelines bot commented Mar 1, 2021

Created a new Microsoft.SecurityInsights preview version - Added onboarding & Offboarding endpoints #12757

Created a new Microsoft.SecurityInsights preview version - Added onboarding & Offboarding endpoints #12757

Conversation

yuvalshilo commented Feb 1, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 • edited Loading

Swagger Validation Report

ghost commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 • edited Loading

Swagger Generation Artifacts

ghost commented Feb 1, 2021 • edited by ghost Loading

openapi-workflow-bot bot commented Feb 1, 2021

ofshomro commented Feb 1, 2021

openapi-workflow-bot bot commented Mar 1, 2021

chiragg4u commented Mar 1, 2021

markcowl left a comment

Choose a reason for hiding this comment

markcowl commented Mar 1, 2021

azure-pipelines bot commented Mar 1, 2021

yuvalshilo commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

ghost commented Feb 1, 2021 •

edited by ghost

Loading